Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commonjs export issue is not fixed completely #975

Closed
andreo-k opened this issue Feb 13, 2019 · 1 comment
Closed

commonjs export issue is not fixed completely #975

andreo-k opened this issue Feb 13, 2019 · 1 comment

Comments

@andreo-k
Copy link

Subject of the issue

There are fixes in 'development' branch which try to fix commonjs export issue (you assign scope.GridStackUI there). However there is still issue

currently:
try { GridStackUI = require('gridstack'); } catch (e) {}

should be added (in bold)
try { GridStackUI = require('gridstack').GridStackUI; } catch (e) {}

Pls see the fix in my fork of the project
https://github.com/andreo-k/gridstack.js
branch v0.4.0-fix-exports

Your environment

  • 0.4.0 and latest 'development' branch
  • latest chrome and firefox

Steps to reproduce

  1. Build application with webpack with disabled AMD ({ parser: { amd: false } })
  2. Try to run application

Expected behaviour

Application runs fine

Actual behaviour

Application fails with 'can not get registerPlugin of undefined'

@radiolips
Copy link
Member

Hey @andreo-k ! Could you put in a PR for this update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants