This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Fix drag drop with Gridstack 0.4.0 #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notebook 5.6 moved to jQuery 3.x. Gridstack needs an upgrade to work with that version. Jumping to GS 0.4 breaks a lot of stuff. The changes here get things limping along, but drag/drop in layout mode is still broken.
|
Hi, I was wondering if you have any idea if this may be merged soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thank you for great plugin. I'm really in to it.
The development here is inactive and not following current Jupyter project. That's sad to me. So I'm trying to make it work with the latest version of Jupyter notebook for several days. As I don't know much about Javascript, nodejs and requirejs, I want a help to fix something odd if they exist.
I started from here. #317
Added gridstack.jQuery.js
First, I tried to load
gridstack.jQueryUI.jsindashboard-view.jswith requirejs. I followed the instruction of thegridstack.js's README. It said I should follow the stackoverflow answer.https://stackoverflow.com/questions/35582945/redundant-dependencies-with-requirejs
After that, to load the file, I modified
gridstack-custom.jsto insertgridstack.jqueryuito define method. But I don't know this is the right way to do it.Use not compiled js file.
There is a bug not only in jupyter-dashboard plugin but also in gridstack.js because I was having
registerPlugin of undefined'error when I loadedgridstack.jQueryUI.jswithgridstack.min.js. But it works withgridstack.js.It seems
GridStackUIvariable is not currently being well handled.gridstack/gridstack.js#975
Currently, it seems like working well. Please let me know something to be done.