Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
With this we have a parachute in case toolchain compilation is broken and some random user needs to be able to build OTP for him/her-self.
This feature requires the docker engine to be up and running.
It expects a docker image tagged
grisp2-rtems-toolchain
to be available.The image must contain a built toolchain under
/grisp2-rtems-toolchain/rtems/5
and haveGRISP_TC_ROOT
andPATH
environment variables set accordingly.The idea here is to use docker just to run toolchain related commands and leave all other stuff to the host erlang and rebar3 installations. That said, this feature needs to mount the project directory as a docker volume inside the container.
To make stuff more simple, the mounted volume has (in the container) the same identical path of the working dir on the host. This will be a problem if we run in a Windows file system.
Here the experimental dockerfile, the image is 6.48 GB and can certainly be lighter although the toolchain alone is pretty big.