Fetch Url Widget Repository behind corporate proxy (#1238) #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The e2e test AdminPanel does not show version ? (!) |
This test may have become unreliable after a recent change. Will look into it. |
(There's a possible fix for the flaky test coming, in the meantime I just reran it) |
georgegevoian
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With a self-hosted instance installed behind a corporate proxy, you cannot fetch a custom url widgets repository.
Proposed solution
Add http proxy settings in order to be able to fetch url widget repository, for instance by reusing GRIST_HTTPS_PROXY and ProxyAgent.
Related issues
#1238
Has this been tested?
Screenshots / Screencasts