allow seed rules to refer to columns #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a small change to the UI for entering seed rules, so that a seed rule that refers to a column may be added. This is a bit niche, but occasionally handy when all tables have some common structure.
dsagal
reviewed
Oct 9, 2024
app/client/aclui/AccessRules.ts
Outdated
| @@ -1809,6 +1817,9 @@ class ObsRulePart extends Disposable { | |||
| private _warnInvalidColIds(colIds?: string[]) { | |||
| if (!colIds || !colIds.length) { return false; } | |||
| const allValid = new Set(this._ruleSet.getValidColIds()); | |||
| // Don't check column validity if we don't have any. | |||
| // For example, the seed rule has no columns. | |||
| if (allValid.size === 0) { return false; } | |||
There was a problem hiding this comment.
I think there are other cases of no-columns:
- the default rule (fallback for all tables). I think it would be hard to impossible to avoid it being an invalid rule then.
- the special rules. Using columns there would probably make them invalid too.
Can we maybe target seed rules more specifically here?
There was a problem hiding this comment.
Ok, will bring back some code for that, this just felt simpler but you're right, it is too broad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a small change to the UI for entering seed rules, so that a seed rule that refers to a column may be added. This is a bit niche, but occasionally handy when all tables have some common structure.
Context
This was motivated by a user's experience adding a seed rule related to UUIDs:
https://community.getgrist.com/t/linkkey-access-rule-for-all-tables/6707
Proposed solution
We wait until a rule set is associated with some columns before checking column validity.
Has this been tested?