Add layouts #1
Merged
Add layouts #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancairl
reviewed
Sep 6, 2024
briancairl
reviewed
Sep 7, 2024
| // We know ptr will be valid asynchronously because we construct it on the | ||
| // stack of main. In real code we might want to use a shared_ptr or | ||
| // something | ||
| return std::async([=] { |
There was a problem hiding this comment.
Its implementation-defined, but I think std::async usually launches a new thread, so its sort of doodoo. But there's no read/write sync on the data pointed to by ptr. I would guess your serial::Serial interfaces do some of their own protection, calling into the same offset could be weird?
briancairl
reviewed
Sep 7, 2024
src/map.cpp
Outdated
|
|
||
| // Populate the Mat with the data from the array (scale from int to 8-bit | ||
| // range) | ||
| for (auto i = 0u; i < Width * Height; ++i) { |
There was a problem hiding this comment.
std::transform(
std::begin(grid),
std::end(grid),
img.begin<uchar>(),
[](auto grid_value) -> uchar
{
return static_cast<uchar>(std::clamp(16 * grid_value, 0, 255));
}
);less loopy index-y, but you probably need grid.begin() and grid.end()
There was a problem hiding this comment.
or i could do neither of those things
save/load from image
griswaldbrooks
force-pushed
the
add-layouts
branch
from
46c64f5
to
f1ce0d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.