Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config reload should re-use unmodified servers #164

Closed
grobian opened this issue Mar 24, 2016 · 2 comments
Closed

config reload should re-use unmodified servers #164

grobian opened this issue Mar 24, 2016 · 2 comments

Comments

@grobian
Copy link
Owner

grobian commented Mar 24, 2016

This is the real reason for issues #156 and #157, plus it will fix issue #150.

Now router is a proper object, it can store the servers separately and create uniques as it goes. When a new router object is created it should be able to merge/compare it with the previous one, to take over unmodified servers. In addition, the changes should be reported such that config differences can be spotted.

@grobian
Copy link
Owner Author

grobian commented Mar 24, 2016

Reason for this is that currently broken servers at the time of config reload will cause all pending metrics to be dropped, while this in fact isn't necessary if the same server remains in the config.

grobian added a commit that referenced this issue Apr 24, 2016
Pulled together the bits to implement issue #164.
@grobian
Copy link
Owner Author

grobian commented May 8, 2016

this is implemented in master

@grobian grobian closed this as completed May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant