Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit code is 0 on error when daemonised #265

Closed
grobian opened this issue Apr 29, 2017 · 0 comments
Closed

exit code is 0 on error when daemonised #265

grobian opened this issue Apr 29, 2017 · 0 comments
Labels
bug

Comments

@grobian
Copy link
Owner

grobian commented Apr 29, 2017

For example when the port used for the relay is already in use, the error is logged, but the exit code is 0. The relay should exit with non-zero code in this case. Only when the relay is actually running it should return 0.
@grobian grobian added the bug label Apr 29, 2017
grobian added a commit that referenced this issue Apr 30, 2017
@grobian
relay: ensure exit code is correct when daemonised, issue #265
00b6828 
Delay sending success to the (grand)parent until we really know we are
ready to serve requests.  This way, listening errors like ports in use
are now reported back and make the start fail.
@grobian grobian closed this as completed Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grobian