Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Log unwanted input metrics . #78

Closed
toni-moreno opened this issue Jun 25, 2015 · 11 comments
Closed

[Feature Request] Log unwanted input metrics . #78

toni-moreno opened this issue Jun 25, 2015 · 11 comments

Comments

@toni-moreno
Copy link

Could be very useful if we can get a log to audit which metrics and the IP sources of unwanted metrics

something like

match  "^caseA"  send cluster_A stop;
match "^caseB" send cluster_B stop;
match "^caseC" send cluster_C stop;
match "*" send blackhole[ /var/log/carbon-c-relay/unwanted.log] stop;

This log should have at least IP origin and metric name.

@grobian
Copy link
Owner

grobian commented Jun 25, 2015

perhaps a special cluster type for this would work too?

cluster log file /var/log/wherever.log;
match * send to log;

@toni-moreno
Copy link
Author

Yes @grobian this would be great to me.!!

When do you think it would be implemented?

@grobian
Copy link
Owner

grobian commented Jul 1, 2015

I need to find some time, which I can't make any guarantees of at the momement. Hope that's ok.

@toni-moreno
Copy link
Author

That's ok.

Thank you very much !!

@grobian
Copy link
Owner

grobian commented Jul 4, 2015

this is a bit more work than I anticipated :) anyway, working on it from the garden now :D

@grobian
Copy link
Owner

grobian commented Jul 4, 2015

OK, got file-logging implemented. IP logging is a small challenge, for that information is not available during log time.

grobian added a commit that referenced this issue Jul 5, 2015
Allow writing to a file as cluster target.  The ip option is
non-functional and will be removed in the next commit.
@grobian
Copy link
Owner

grobian commented Jul 23, 2015

would you be very disappointed if IP logging was not available?

@toni-moreno
Copy link
Author

Ummmm... I can understand the challenge, and of course l'll be happy to use carbon-c-relay anyway.

There is any other way to detect who ( ip source) are sending unwanted metrics ?

@grobian
Copy link
Owner

grobian commented Jul 25, 2015

Ok, then I'll keep this request open.

@grobian
Copy link
Owner

grobian commented Sep 27, 2015

source ip implemented in 7d3c3c5

@grobian grobian closed this as completed Sep 27, 2015
@toni-moreno
Copy link
Author

Hi @grobian .

I'm really happy to see this Feature Request full done !!

I will try to give you feedback as soon as i could compile and test it.

Lots of thanks !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants