Issue 219: Should fail if <port> isn't available on IPv4 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobian
requested changes
Oct 15, 2016
|
I have fixed the spacing issues to use tabs and per the comment on #219, removed the -A flag in order to require all ports to be bound. |
justincmoy
changed the title
grobian
approved these changes
Oct 15, 2016
| @@ -96,6 +97,11 @@ bindlisten( | |||
| } | |||
|
|
|||
| if (bind(sock, resw->ai_addr, resw->ai_addrlen) < 0) { | |||
| logout("failed to bind on %s%d port %s\n", | |||
There was a problem hiding this comment.
I would move the saddr block before this if-branch, such that you can use saddr in the error message. Should the OS for some reason return multiple addresses (other than the ALL interface) it is at least reported, but also adds consistency with the OK message lateron.
grobian
added a commit
that referenced
this pull request
Oct 15, 2016
Cleanup before when bind() fails, and also cleanup and return when listen() fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #219: Should fail if isn't available on IPv4