Short-circuit interface binding on error #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I see, dumb dumb the addr loop is in there, so it doesn't really exit the function, which was supposed to happen. |
grobian
reviewed
Oct 18, 2016
| @@ -55,7 +55,7 @@ bindlisten( | |||
| struct addrinfo *res, *resw; | |||
| char buf[128]; | |||
| char saddr[INET6_ADDRSTRLEN]; | |||
| int err; | |||
| int err, binderr = 0; | |||
There was a problem hiding this comment.
Nitpicking, but could you put this one on a line by itself? Also I usually use a char for these.
There was a problem hiding this comment.
Sure, not a problem. Just pushed it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fix for #219. The logic in receptor.c causes interfaces to continue being processed after failure to create/bind a socket, as it only breaks out of the address loop. It also treats socket creation failures as non-terminal (not a likely error, but might as well be thorough). The ensures that any error in socket creation/binding stops the process.