Moves writeback to outside of lock #274
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all dispatchers are blocking on an
invlock
held byaggregator_expire
, and sufficient metrics have been sent back into the system but not yet read, the system can deadlock withaggregator_expire
blocking on the socket write, while the threads that could free space in the FIFO are blocking onaggregator_expire
.While
aggregator_expire
holds the lock, don't write metrics but instead accumulate them to a NUL-separated buffer. After releasing the lock, write the metrics to the fd one at a time so that we can properly tracksent
anddropped
metrics.