Correct route using from sending the rewritten key
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `route using` it shouldn't send the rewritten key
|
@grobian Can this be merged? |
|
In principle yes, but I'm still trying to find time to understand the issue and check why it doesn't this already. Looking at it with a fresher mind, it seems because ch_get_nodes implicitly adds the metric to the returned node list, which is wrong. |
grobian
added a commit
that referenced
this pull request
Jul 19, 2017
This is an alternative take to the original PR. Instead of having ch_get_nodes copy the metric into the destinations struct (undocumented), perform the copy in router_route_intern, like for all other cases. This is more transparent, and ensures that the correct metric is added to the send queue.
|
instead of adding an extra param to ch_get_nodes, I changed it not to copy metric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use the rewritten key for determining where to route. It shouldn't send the rewritten key.