Checkin assets with no assigned user #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the isdigit() check for the Snipe asset tag as this creates issues when a non-digit prefix is used.
Fix asset tag only updating when number
Exceptions aren't very likely during this initialization step, but if they occur the user definitely wants to know about them.
I fixed two condition checks to make sure the data from Jamf and the data from Snipe are aligned. These are successfully set attributes, but showing as failing because the data doesn't line up at time of comparison. Snipe adds " 00:00:00" to the date, and json reports None for a blank value while the Jamf data contains an empty string. By doing these two conditional checks, I stop getting 3 warnings for ever machine updating that has these attributes updating in the case of purchase date, or not changing as is the case with my empty custom attributes.
Fixed two condition checks for confirming updating fields
Print exceptions during is-up detection
This is helpful to run the same script in multiple environments, where adapting the `settings.conf` file might not be possible or desirable.
This moves the sample settings.conf file to settings.conf.example to help users and developers avoid accidentally committing and publishing their credentials.
|
@elyscape First off, thanks for making all these PRs. I finally got around to merging all of them. Can I bother you to redo this one? I think it generated a significant number of merge conflicts. Sorry. |
|
Actually I'm going to close this for now. As I mentioned in the previous ticket, code looks good to me, but let's add it as a runtime flag. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #68