Removed curly braces around file extension in collectCoverageForm in … #4109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…package.json to generate code coverage report with jest
Signed-off-by: Jessica Filben [email protected]
What does this PR do?
Normally jest testing is setup to display testing coverage when the command
yarn test --coverage
is run. However, when the command was run the coverage was not being shown. The cause of this problem is in the jest configuration settings in package.json under collectCoverageFrom. The curly braces around the file extensions need to be removed for the testing coverage to work properly.Where should the reviewer start?
Look at the following issue explaining the curly braces problem in jest.
Relevant documentation of issue: jestjs/jest#6654
Then look at the package.json file and see the changes that were made. Test out the
yarn test --coverage
command.What testing has been done on this PR?
All tests passed and I manually tested the
yarn test --coverage
command by opening theindex.html
file found in thecoverage/lcov-report
folder.How should this be manually tested?
Run
yarn test --coverage
and open theindex.html
file found in thecoverage/lcov-report
folder to view the test coverage report.Any background context you want to provide?
N/A
What are the relevant issues?
N/A
Screenshots (if appropriate)
How the test coverage report looks before the curly braces in collectCoverageFrom were removed:
How the test coverage report looks after:
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
No
Is this change backwards compatible or is it a breaking change?
It is backwards compatible