Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed curly braces around file extension in collectCoverageForm in … #4109

Merged
merged 2 commits into from
May 26, 2020
Merged

Removed curly braces around file extension in collectCoverageForm in … #4109

merged 2 commits into from
May 26, 2020

Conversation

jcfilben
Copy link
Collaborator

…package.json to generate code coverage report with jest

Signed-off-by: Jessica Filben [email protected]

What does this PR do?

Normally jest testing is setup to display testing coverage when the command yarn test --coverage is run. However, when the command was run the coverage was not being shown. The cause of this problem is in the jest configuration settings in package.json under collectCoverageFrom. The curly braces around the file extensions need to be removed for the testing coverage to work properly.

Where should the reviewer start?

Look at the following issue explaining the curly braces problem in jest.
Relevant documentation of issue: jestjs/jest#6654
Then look at the package.json file and see the changes that were made. Test out the yarn test --coverage command.

What testing has been done on this PR?

All tests passed and I manually tested the yarn test --coverage command by opening the index.html file found in the coverage/lcov-report folder.

How should this be manually tested?

Run yarn test --coverage and open the index.html file found in the coverage/lcov-report folder to view the test coverage report.

Any background context you want to provide?

N/A

What are the relevant issues?

N/A

Screenshots (if appropriate)

How the test coverage report looks before the curly braces in collectCoverageFrom were removed:
Screen Shot 2020-05-22 at 11 49 28 AM
How the test coverage report looks after:
Screen Shot 2020-05-22 at 10 46 37 AM

Do the grommet docs need to be updated?

No

Should this PR be mentioned in the release notes?

No

Is this change backwards compatible or is it a breaking change?

It is backwards compatible

…package.json to generate code coverage report with jest

Signed-off-by: Jessica Filben <[email protected]>
@ShimiSun
Copy link
Collaborator

I don't think the Chromatic failures are related to this change, I've rerun the build to see if anything changes.

@ShimiSun
Copy link
Collaborator

#4117

@ShimiSun ShimiSun merged commit 07efff7 into grommet:master May 26, 2020
@ShimiSun
Copy link
Collaborator

Great work, thank you for your contribution!

@jcfilben jcfilben deleted the fix/collectCoverageFrom branch June 9, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants