-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/accessibility-structure: added new pages and card previews for accessibility hub #2145
base: master
Are you sure you want to change the base?
Feat/accessibility-structure: added new pages and card previews for accessibility hub #2145
Conversation
…ystem into feat/accessibility-structure
@amandadupell looks like we're getting failing checks here -- likely need to update yarn.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having a variety of thoughts stirring around how we might make adjustments to this content in a way that tells more of a story. Right now, it's starting to feel a bit overwhelming with the number of cards and links and paths I could go.
Still need to simmer a little more on what I might recommend, but just want to comment to start the discussion. Wondering how we might make some this feel more like a sequence of things to explore.
I agree with @taysea 's instinct here. Perhaps we should take a moment to pause here and see whether or not we are in alignment with our compass heading here? It feels like we have assembled a great collection of resources, however we aren't exactly clear as to what our objective and storyline is. I have jotted down some starting thoughts and will elaborate on these, but noting them as a draft for now. DRAFT Proposed Storyline:
|
What does this PR do?
Restructures the Accessibility page to be a hub with spokes. Added new card previews with simple icon UI for new pages.
Where should the reviewer start?
Accessibility page then all newly created MDX files.
What testing has been done on this PR?
Manual testing.
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Running locally or deployment link
Any background context you want to provide?
What are the relevant issues?
#1816 #2118
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Yes
Is this change backwards compatible or is it a breaking change?
Backwards compatible