Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/content-changes2214: added content changes based on comments from will #2215

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

amandadupell
Copy link
Contributor

What does this PR do?

This PR makes content changes to the Accessibility page based on comment from this Figma file.

The changes are:

  • Updating the "Accessibility in Design" and "Accessibility in Development" headers to be "Designing for Accessibility" and "Developing for Accessibility" to align with "Testing for Accessibility"
  • Reorganize the "Designing for Accessibility" section to have better flow and visual separation
  • Change ordered list in the "Testing for Accessibility" section to a bulleted list so it's not seen as a "step-by-step" guaranteed process
  • Rephrase and shorten bolded sentences from "Testing for Accessibility" to be clear and concise
  • Add introduction sentence to "Automated Testing Tools" section

Where should the reviewer start?

Accessibility page

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

#2214 #1816

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

No

Is this change backwards compatible or is it a breaking change?

Compatible

@amandadupell amandadupell linked an issue Jan 18, 2022 that may be closed by this pull request
Copy link
Collaborator

@britt6612 britt6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding source the rest looks good to me

Copy link
Collaborator

@halocline halocline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd like @taysea to have a chance to read through prior to merging.


## Accessibility in Development
## Developing for Accessibility
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

design decisions. Each HPE Design System Figma file contains a "Use Cases
and Research" page detailing the considerations and decision making process
for a given component.
Each HPE Design System Figma file contains a "Use Cases and Research" page detailing the considerations and decision making process for a given component. Usability testing and best practice research build the foundation for all design decisions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -56,20 +50,22 @@ For guidance on setting up your development environment, see [Developer Guidance

## Testing for Accessibility

The following are steps you should look to incorporate into your workflow to better test and ensure accessibility across the board:
The following are actions you can incorporate into your workflow to better test and ensure accessibility across the board:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice collaboration with @CitizenFox on this. Thank you both.

Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, nice work.

@taysea taysea merged commit 51493af into grommet:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility page - Content Changes Based on Figma Comments
4 participants