-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/content-changes2214: added content changes based on comments from will #2215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding source the rest looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'd like @taysea to have a chance to read through prior to merging.
|
||
## Accessibility in Development | ||
## Developing for Accessibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
design decisions. Each HPE Design System Figma file contains a "Use Cases | ||
and Research" page detailing the considerations and decision making process | ||
for a given component. | ||
Each HPE Design System Figma file contains a "Use Cases and Research" page detailing the considerations and decision making process for a given component. Usability testing and best practice research build the foundation for all design decisions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -56,20 +50,22 @@ For guidance on setting up your development environment, see [Developer Guidance | |||
|
|||
## Testing for Accessibility | |||
|
|||
The following are steps you should look to incorporate into your workflow to better test and ensure accessibility across the board: | |||
The following are actions you can incorporate into your workflow to better test and ensure accessibility across the board: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice collaboration with @CitizenFox on this. Thank you both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, nice work.
What does this PR do?
This PR makes content changes to the Accessibility page based on comment from this Figma file.
The changes are:
Where should the reviewer start?
Accessibility page
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
#2214 #1816
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
No
Is this change backwards compatible or is it a breaking change?
Compatible