Update datatable.mdx #3499
Open
Update datatable.mdx #3499
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the datatable guidance to cover the right alignment of numerical data, dates and time stamps. Also include information around the alignment of column header labels, it should match the alignment of the contents.
A minor change in wording
taysea
reviewed
Aug 4, 2023
Taylor, thank you for the updated wording Co-authored-by: Taylor Seamans <[email protected]>
Taylor, I added a blurb about the 'primary identifier' - feel that is important detail when it comes to the correct set of column.
Taylor, one last word smithing exercise
|
@julauxen This PR is a bit outdated but the content might still be useful. Can you have a look and see if it's still worth adding and any feedback? |
|
Hey @taysea, there'a a lot going on with this PR. I never worked on data table, so I am adding @CillianHPE and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the datatable guidance to cover the right alignment of numerical data, dates and time stamps. Also include information around the alignment of column header labels, it should match the alignment of the contents.
Deploy Preview
What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?