Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Metric2 #3529

Closed
wants to merge 2 commits into from
Closed

Explore Metric2 #3529

wants to merge 2 commits into from

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Aug 31, 2023

Deploy Preview

What does this PR do?

This is a draft PR to be able to assess Metric2.

Setup:

  • Use Metric2 fonts locally
  • Also, exploring use of rem as opposed to px for more modern behavior of font scaling based on browser settings

Notes:

  • Metric2 has a bigger x-height, so the fonts appear "bigger" than before
  • Because of the bigger x-height, the line heights also come across a bit tight compared to before
  • The "bold" weight seems to be a little lighter than our current bold

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Related to #3522

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea marked this pull request as draft August 31, 2023 21:14
@taysea
Copy link
Collaborator Author

taysea commented Sep 19, 2024

Closing this work is superseded by #4158

@taysea taysea closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant