Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicators page #3784

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add loading indicators page #3784

wants to merge 6 commits into from

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Mar 7, 2024

Deploy Preview

What does this PR do?

Add loading indicators page.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@julauxen
Copy link
Collaborator

Hi @jcfilben, I added the text I already had and I think for now we can add the examples we already have under each variant. So basically copy/paste the main examples from each specific page. I tried to do it by myself but failed miserably kkkk

@jcfilben
Copy link
Collaborator

Hi @jcfilben, I added the text I already had and I think for now we can add the examples we already have under each variant. So basically copy/paste the main examples from each specific page. I tried to do it by myself but failed miserably kkkk

I added the examples under each variant, let me know if that looks okay

@julauxen
Copy link
Collaborator

julauxen commented Mar 14, 2024

It looks great, thanks @jcfilben! I will work on the do's and don'ts and let you know when i have them ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants