Update Guidance for RadioButtonGroup #4066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketa8
changed the title
luketa8
changed the title
julauxen
reviewed
Aug 1, 2024
taysea
reviewed
Aug 2, 2024
taysea
reviewed
Aug 2, 2024
Co-authored-by: Taylor Seamans <[email protected]>
julauxen
reviewed
Sep 30, 2024
| @@ -29,9 +29,11 @@ import { | |||
|
|
|||
| ### When to use | |||
|
|
|||
| RadioButtonGroup is used to lay out a discreet list of mutually related options that are easily visible. RadioButtonGroup requires an input choice, so it is important to be clear with what is being asked of the user on the label. | |||
| RadioButtonGroup is used to lay out a list of distinct, mutually exclusive options that are easily visible. Since a selection is required, it’s important to be clear with what is being asked of the user on the label. | |||
There was a problem hiding this comment.
I am guessing the phrase "since a selection is required" means "once an option is selected, it does not allow for deselection" so I would suggest:
Once an option is selected it does not allow for deselection, so it’s important to be clear with what is being asked of the user on the label.
@luketa8 is this the right interpretation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy Preview
Issue
What does this PR do?
Update guidance for RadioButtonGroup clarifying its usage for filtering
Where should the reviewer start?
Clear selection discovery
Clear selection Figma