Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft homepage refresh #4136

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Draft homepage refresh #4136

wants to merge 18 commits into from

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Aug 30, 2024

Deploy Preview

What does this PR do?

Draft of a small home page refresh exploration proposed by Chris. This doesn't touch any broader content restructuring aside from taking a "small step" towards a side bar navigation

Some to do's:

  • For the "Search" experience, using keyboard to move down through search results does not keep the active item in view. This could be a Grommet bug.
  • Connect with Julia to get her thoughts on the structure.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for unrivaled-bublanina-3a9bae failed.

Name Link
🔨 Latest commit 44cf8cc
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/6734f030050ee600080c845b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant