Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear selection prototype #4207

Closed
wants to merge 2 commits into from
Closed

Add clear selection prototype #4207

wants to merge 2 commits into from

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Sep 25, 2024 •
edited
Loading

Deploy Preview

What does this PR do?

See the two options in the Deploy Preview above.

NOTES:

  • In Grommet, "Clear selection" when there is no search is automatically receiving focus when Drop opens and therefore "active" styling.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea mentioned this pull request Oct 2, 2024
Open
@taysea
Copy link
Collaborator Author

taysea commented Oct 28, 2024

Closing in favor of grommet/grommet-theme-hpe#412

@taysea taysea closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taysea