Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cgroup v2 #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support cgroup v2 #5

wants to merge 4 commits into from

Conversation

MatMaul
Copy link

@MatMaul MatMaul commented Feb 27, 2021

For now RSS, open FDs and sockets are not supported.

@MatMaul MatMaul force-pushed the cgroupv2 branch 5 times, most recently from 6a0115f to ffbd9cf Compare February 27, 2021 23:19
@MatMaul
Copy link
Author

MatMaul commented Feb 27, 2021

There is also a second commit adding total cpu usage (vs only user).
I didn't push an independent PR because it would conflict, but I can remove it and send it later (after the first is merged) if you want.
Since it is pretty small, simple and in an independent commit I thought it was ok to bundle it.

@MatMaul
Copy link
Author

MatMaul commented Feb 27, 2021

Oh I forgot it also add mem+swap metric hum. let me know if you want to break it further completely or if this is fine for review.

@atotto
Copy link
Member

atotto commented Apr 30, 2021

Thank you for your PR! I will review this commit.

@atotto atotto self-requested a review April 30, 2021 07:31
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@MatMaul
Copy link
Author

MatMaul commented Apr 30, 2021

Thanks for the review ! I merged your suggestions.

@MatMaul MatMaul requested a review from atotto May 3, 2021 16:08
@atotto
Copy link
Member

atotto commented May 6, 2021

Did you get the container_memsw_usage_bytes metrics in cgroup-v1 (Legacy and Hybrid) system?

I cannot read it (all container_memsw_usage_bytes are zero)

container_memsw_usage_bytes{id="/system.slice/ssh.service"} 0
container_memsw_usage_bytes{id="/system.slice/avahi-daemon.service"} 0
container_memsw_usage_bytes{id="/system.slice/NetworkManager.service"} 0

We need test environment..

@atotto atotto self-requested a review May 6, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants