Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added ci builds, tests, and deploys #18

Conversation

Mastermindzh
Copy link
Contributor

This PR adds ci builds using Github actions.
Two of the steps are disabled:

  • Deploy step, it needs secrets set up on the maintainer's part (see: documentation
  • Tests, as described in issue Tests are not portable #17, tests are currently not quite portable enough for me to set up in CI

fixes #15

@pascal89
Copy link
Contributor

Nice. I think the test project can be converted to be able to run it in the pipeline. Have a look at this PR: #13 ;-)

@Mastermindzh
Copy link
Contributor Author

Oh I agree, just didn't have the time to do it (read: didn't want to invest more at the time) 😄.
Are you waiting on it to do your IGrowthBook tests?

@darklordzw
Copy link
Collaborator

@pascal89, PR #13 has been merged into main.

@Mastermindzh
Copy link
Contributor Author

I'll fix this after eating 😄 , Thanks for merging #13

…eature/automated-github-builds-test-and-deploy
@Mastermindzh
Copy link
Contributor Author

@darklordzw,

Let me know how you want to do this merge. I got all the tests moved over to XUnit.

You can see the PR here: frontlinersnl#1
You can see the test results here: https://github.com/Inforitnl/growthbook-c-sharp/actions/runs/6698308487/job/18200066562?pr=1
And on this picture:
image

We can go 1 of 2 ways:

  1. I can merge the PR#1 on our INFORIT branch, which will update this PR
  2. You can merge this PR and then I will make a new one that will enable tests.

Just let me know and I'll make it happen 😄.

This will fix #17

@darklordzw darklordzw merged commit 4e993f1 into growthbook:main Nov 6, 2023
@darklordzw
Copy link
Collaborator

@Mastermindzh, option #2 sounds good. I've merged this PR into main. Once the tests are ready, I'll update the secrets for the deploy step.

Thanks again for all your help!

@Mastermindzh Mastermindzh mentioned this pull request Nov 6, 2023
@Mastermindzh
Copy link
Contributor Author

No problem @darklordzw 😄.

Things were taking a while at our side so I decided to just do some stuff over the weekends/evenings to get the ball rolling.
Thanks for being so quick with reviews & merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up automated builds with Github actions
3 participants