Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prerequisite Flags, Sticky Bucketing, and SemVer Targeting #16

Merged
merged 19 commits into from
Apr 12, 2024
Merged

Prerequisite Flags, Sticky Bucketing, and SemVer Targeting #16

merged 19 commits into from
Apr 12, 2024

Conversation

jdorn
Copy link
Member

@jdorn jdorn commented Apr 4, 2024 •
edited
Loading

Update to spec version 0.5.4

Changes

  • Fixed multiple bugs and edge cases when comparing different data types
  • Fixed bugs with the $in and $nin operators
  • It now ignores unknown fields in feature definitions instead of throwing exceptions (loose unmarshalling)
  • Support for semantic version comparisons
  • Prerequisite flags support
  • Sticky bucketing support
  • Adds Python 3.12 to CI

TODO:

  • Fix type errors
  • Add unit tests for the StickyBucketServiceInterface
  • Clean up code
  • Update README

@jdorn jdorn changed the title Update to spec version 0.5.4 Prerequisite Flags and Sticky Bucketing Support Apr 6, 2024
@jdorn jdorn changed the title Prerequisite Flags and Sticky Bucketing Support Prerequisite Flags, Sticky Bucketing, and Semantic Version Comparison Support Apr 6, 2024
@jdorn jdorn changed the title Prerequisite Flags, Sticky Bucketing, and Semantic Version Comparison Support Prerequisite Flags, Sticky Bucketing, and SemVer Comparisons Apr 6, 2024
@jdorn jdorn changed the title Prerequisite Flags, Sticky Bucketing, and SemVer Comparisons Prerequisite Flags, Sticky Bucketing, and SemVer Targeting Apr 6, 2024
@jdorn jdorn marked this pull request as ready for review April 9, 2024 14:11
bryce-fitzsimons
bryce-fitzsimons reviewed Apr 9, 2024
View reviewed changes
growthbook.py Outdated Show resolved Hide resolved
This was linked to issues Apr 10, 2024
Add Python3.12 #10
Closed
Support bucketVersion kwarg for FeatureRule #15
Closed
@jdorn jdorn merged commit 3d411a3 into main Apr 12, 2024
7 checks passed
@jdorn jdorn deleted the spec-5-4 branch April 12, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryce-fitzsimons bryce-fitzsimons bryce-fitzsimons left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support bucketVersion kwarg for FeatureRule Add Python3.12
2 participants
@jdorn @bryce-fitzsimons