Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Fix grammar mistakes in readme #11

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Fix grammar mistakes in readme #11

merged 2 commits into from
Apr 18, 2018

Conversation

dominikh
Copy link
Contributor

No description provided.

@knweiss
Copy link
Contributor

knweiss commented Apr 18, 2018

The 2nd hunk is fixed in master already. The first trivial hunk is still required. Merge?

@brancz
Copy link
Collaborator

brancz commented Apr 18, 2018

This needs a rebase but not blocking #43

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@bwplotka
Copy link
Collaborator

I rebased manually using Github UI, but it seems I made Googlebot sad by that.

I guess it's fair to have @dominikh "ok" for it, but the change is quite straightforward.

@codecov-io
Copy link

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files           8        8           
  Lines         271      271           
=======================================
  Hits          213      213           
  Misses         49       49           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe3f5b2...84d6314. Read the comment docs.

@dominikh
Copy link
Contributor Author

This is a single character documentation fix that took 1.5 years, involved four people and two bots, and now contains an unnecessary merge commit instead of a straightforward rebase.

Nothing about this is "ok", but legally speaking I'm fine with this being merged…

@brancz brancz merged commit 3a0e610 into grpc-ecosystem:master Apr 18, 2018
@bwplotka
Copy link
Collaborator

Lmao

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants