-
Notifications
You must be signed in to change notification settings - Fork 164
Conversation
This fixes: client_test.go:210:3: should replace count += 1 with count++ server_test.go:233:3: should replace count += 1 with count++
This fixes: client_metrics.go:122:1: comment on exported method ClientMetrics.StreamClientInterceptor should be of the form "StreamClientInterceptor ..."
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Please see #40 regarding the Travis-CI failure. |
@brancz done |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
======================================
Coverage 77.4% 77.4%
======================================
Files 8 8
Lines 270 270
======================================
Hits 209 209
Misses 52 52
Partials 9 9
Continue to review full report at Codecov.
|
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Please review.