Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Trivial golint fixes #44

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Trivial golint fixes #44

merged 2 commits into from
Apr 18, 2018

Conversation

knweiss
Copy link
Contributor

@knweiss knweiss commented Apr 17, 2018

Please review.

This fixes:
client_test.go:210:3: should replace count += 1 with count++
server_test.go:233:3: should replace count += 1 with count++
This fixes:
client_metrics.go:122:1: comment on exported method ClientMetrics.StreamClientInterceptor should be of the form "StreamClientInterceptor ..."
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@knweiss
Copy link
Contributor Author

knweiss commented Apr 17, 2018

Please see #40 regarding the Travis-CI failure.

@knweiss knweiss mentioned this pull request Apr 17, 2018
@brancz
Copy link
Collaborator

brancz commented Apr 18, 2018

Same as in #45 .

@knweiss you also need to sign the CLA for us to be able to merge these changes. Also even if flaky I'd prefer to see the tests pass.

@knweiss
Copy link
Contributor Author

knweiss commented Apr 18, 2018

@brancz done

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #44   +/-   ##
======================================
  Coverage    77.4%   77.4%           
======================================
  Files           8       8           
  Lines         270     270           
======================================
  Hits          209     209           
  Misses         52      52           
  Partials        9       9
Impacted Files Coverage Δ
client_metrics.go 74.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e2f48...83d16be. Read the comment docs.

@brancz
Copy link
Collaborator

brancz commented Apr 18, 2018

lgtm

@brancz brancz merged commit b089b26 into grpc-ecosystem:master Apr 18, 2018
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants