Add CHANGELOG.md entry for v1.2.0 #53
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 78.59% 78.59%
=======================================
Files 8 8
Lines 271 271
=======================================
Hits 213 213
Misses 49 49
Partials 9 9Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
|
|
||
| ### Removed | ||
|
|
||
| n/a |
There was a problem hiding this comment.
n/a? What do you mean? That we don't have changelog for below and 1.1.0 or what?
There was a problem hiding this comment.
if that is the case, can we actually put 1.1 and 1.0 headers with n/a mention (or more verbose version "changelog started from 1.2")
There was a problem hiding this comment.
n/a stands for not applicable, because there was nothing removed in this release
CHANGELOG.md
Outdated
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [1.2.0] - 2018-06-04 |
There was a problem hiding this comment.
worth to add actual link to (non-existing yet) 1.2.0 release on github (https://github.com/grpc-ecosystem/go-grpc-prometheus/releases/tag/v1.2)
There was a problem hiding this comment.
I definitely agree this comment.
Closes #52 #43
@Bplotka