Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-swagger comment parsing for documentation gen #128

Closed
jacmarjorie opened this issue Mar 14, 2016 · 2 comments · Fixed by #134
Closed

protoc-gen-swagger comment parsing for documentation gen #128

jacmarjorie opened this issue Mar 14, 2016 · 2 comments · Fixed by #134

Comments

@jacmarjorie
Copy link

Is there, by chance, any documentation on how to properly format comments so that the swagger fields in the JSON will be nicely populated for documentation purposes?

@achew22
Copy link
Collaborator

achew22 commented Mar 15, 2016

Unfortunately that is not something that I implemented. Fortunately I don't think it would be extremely difficult if you wanted to take a swing at contributing.

The comments are in the SourceCodeInfo_Location object inside the FileDescriptorProto when genswagger iterates over the files.

If you need more pointers than that please comment on this issue and I'll see what I can do.

Thanks for reaching out!

ivucica added a commit to ivucica/grpc-gateway that referenced this issue Apr 17, 2016
While this is a first step in resolving grpc-ecosystem#128, this
needs to be cleaned up, and the same approach needs to be used for
messages, message fields, et al.

echo_service.proto has been annotated with extra comments in order to
demo the new descriptions.

Only the Swagger example has been regenerated, as my local generator
does not output all the expected fields in proto struct tags.
ivucica added a commit to ivucica/grpc-gateway that referenced this issue Apr 18, 2016
While this is a first step in resolving grpc-ecosystem#128, this
needs to be cleaned up, and the same approach needs to be used for
messages, message fields, et al.

echo_service.proto has been annotated with extra comments in order to
demo the new descriptions.

Only the Swagger example has been regenerated, as my local generator
does not output all the expected fields in proto struct tags.
@kellrott
Copy link

kellrott commented May 5, 2016

It looks like #134 covers this issue. Hopefully that will be merged in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants