Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to v2 migration guide broken #1836

Closed
jrgirvan opened this issue Nov 23, 2020 · 3 comments · Fixed by #1839
Closed

Link to v2 migration guide broken #1836

jrgirvan opened this issue Nov 23, 2020 · 3 comments · Fixed by #1839

Comments

@jrgirvan
Copy link

jrgirvan commented Nov 23, 2020

📚 Documentation

There are a few links to the Migration guide, notably on https://github.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.0.0
But the link results in a 404

Broken Link
https://grpc-ecosystem.github.io/grpc-gateway/docs/v2-migration.html

Should point to
https://grpc-ecosystem.github.io/grpc-gateway/docs/development/v2-migration/

@johanbrandhorst
Copy link
Collaborator

Doh, thanks for the issue! This was caused by us reorganizing the links a bit. Will do a pass and clean up any missing references.

@vibhordubey333
Copy link

📚 Documentation

There are a few links to the Migration guide, notably on https://github.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.0.0
But the link results in a 404

Broken Link
https://grpc-ecosystem.github.io/grpc-gateway/docs/v2-migration.html

Should point to
https://grpc-ecosystem.github.io/grpc-gateway/docs/development/v2-migration/

None of above link is working now. :-(

@johanbrandhorst
Copy link
Collaborator

The correct link is https://grpc-ecosystem.github.io/grpc-gateway/docs/development/grpc-gateway_v2_migration_guide/, I will go around and update the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants