Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow whitelisting of particular HTTP headers to map to metadata. #253

Closed
tmc opened this issue Nov 6, 2016 · 4 comments
Closed

Allow whitelisting of particular HTTP headers to map to metadata. #253

tmc opened this issue Nov 6, 2016 · 4 comments

Comments

@tmc
Copy link
Collaborator

tmc commented Nov 6, 2016

In #252 we allow a fixed set of HTTP headers to be sent on to the grpc call in the form of metadata (with the 'grpcgateway-' prefix). There should be a mechanism to whitelist additional headers.

@tmc
Copy link
Collaborator Author

tmc commented Jan 11, 2017

IMO the best way to do this is via a new https://godoc.org/github.com/grpc-ecosystem/grpc-gateway/runtime#ServeMuxOption

@fiibbb
Copy link

fiibbb commented Mar 8, 2017

Hi @tmc, does this mean allowing HTTP headers not with grpcgateway- prefix to be also passed to GRPC? If so, I'm interested in this feature. Is it actively being worked on?

@tmc
Copy link
Collaborator Author

tmc commented Mar 8, 2017

@fiibbb it's not super specified but could encompass what you're describing

@tmc
Copy link
Collaborator Author

tmc commented Apr 19, 2017

with #336 landed I think this can be considered closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants