-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass permanent HTTP request headers #252
Conversation
@willnorris any info on the cla/google check hanging? |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Ah. @christianvozar can you fill out the google cla at https://cla.developers.google.com ? |
@tmc, as noted in the comment from @googlebot, @christianvozar has already signed the CLA (emphasis added):
Them problem is that you are submitting a pull request including code authored by someone else, so we just want that someone else to confirm that they're okay with their code being contributed to the project. The CLA status won't actually change from it's current state, but it's okay to merge once @christianvozar has indicated agreement. |
@willnorris this project uses GitHub's protected branches feature to prevent direct pushes to master -- how likely is it that the googlebot will learn how to deal with this situation? @yugui if the answer is not likely then we I/we need another path to get these types of PRs in. |
@christianvozar Can I merge your contribution in this PR into this repository? |
* Pass Permanent Request Headers * Fix tests and update pr213
This is a rework/revival of #213 with the following changes:
Further work would include the ability to explicitly whitelist additional parameters but we should do that in a separate diff.