Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime v2.15.1 can't be used with apps with klog #3204

Closed
jmuk opened this issue Feb 23, 2023 · 0 comments · Fixed by #3205
Closed

runtime v2.15.1 can't be used with apps with klog #3204

jmuk opened this issue Feb 23, 2023 · 0 comments · Fixed by #3205

Comments

@jmuk
Copy link
Contributor

jmuk commented Feb 23, 2023

🐛 Bug Report

Updating the app dependency to grpc-gateway v2.15.1 causes breakage upon runtime. It gets panicked as flag redefined: alsologtostderr.

It appears that I'm using k8s.io/klog/v2 for the logging library, but grpc-gateway/v2/runtime now started using glog, and they are conflicting with each other for some of flag names.

To Reproduce

  1. Set up a grpc-gateway server with klog. use v2.15.0
  2. go get github.com/grpc-ecosystem/grpc-gateway/v2 to update to v2.15.1
  3. build
  4. run

Expected behavior

Runs as usual.

Actual Behavior

runtime panic with flag redefined: alsologtostderr

Your Environment

Any OS, any Go version.
jmuk added a commit to jmuk/grpc-gateway that referenced this issue Feb 23, 2023
@jmuk
Switch the use of glog to grpclog.
d7a25de 
It appears other files in runtime package are using grpclog, there's
no reason to use glog in context.go.

Fixes grpc-ecosystem#3204
@jmuk jmuk mentioned this issue Feb 23, 2023
Merged
johanbrandhorst pushed a commit that referenced this issue Feb 23, 2023
@jmuk
Switch the use of glog to grpclog. (#3205)
e5a69e1 
It appears other files in runtime package are using grpclog, there's
no reason to use glog in context.go.

Fixes #3204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch the use of glog to grpclog. jmuk/grpc-gateway
1 participant
@jmuk