Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import_path option not working as intended #536

Closed
shynie opened this issue Feb 2, 2018 · 1 comment
Closed

import_path option not working as intended #536

shynie opened this issue Feb 2, 2018 · 1 comment

Comments

@shynie
Copy link

shynie commented Feb 2, 2018

This option doesn't work the same way it does with protoc-gen-go. The latter has option M that allows us to associate a set of *.proto files with package given in import_path, so all of the generated *.go files will have the same package name.

Mfoo/bar.proto=quux/shme - declares that foo/bar.proto is associated with Go package quux/shme. This is subject to the import_prefix parameter.

protoc-gen-grpc-gateway should support that option too. Now importh_path only changes the path but doesn't affect package names.

@achew22
Copy link
Collaborator

achew22 commented Feb 2, 2018

@shynie, thanks for the bug report!

Unfortunately, I'm not at all familiar with the argument you're attempting to use. Do you think you could point to some documentation that has more information? Additionally it would be extremely helpful if you could write a test that demonstrates this failure. With that it will be a lot easier to figure out what next steps should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants