New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #119 - CloseNotify race with ServeHTTP #120

Merged

yugui merged 1 commit into grpc-ecosystem:master from cuongdo:fix_close_notify_race

Mar 3, 2016

Commits on Mar 2, 2016

Fix grpc-ecosystem#119 - CloseNotify race with ServeHTTP

The generated code for the mux handlers can panic if the call to
ServeHTTP() finishes before the goroutine finishes. This is because
CloseNotify() can only be called before ServeHTTP() finishes. I've
fixed this by calling CloseNotify() before starting the goroutine. The
returned channel can safely be selected any time after that.

Cuong Do committed Mar 2, 2016