Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoD 2020] Added new documentation website for gRPC-Gateway #1786

Merged
merged 14 commits into from
Nov 3, 2020
Merged

[GSoD 2020] Added new documentation website for gRPC-Gateway #1786

merged 14 commits into from
Nov 3, 2020

Conversation

iamrajiv
Copy link
Contributor

@iamrajiv iamrajiv commented Nov 2, 2020

Added new documentation website for gRPC-Gateway.

@google-cla google-cla bot added the cla: yes label Nov 2, 2020
@iamrajiv iamrajiv changed the title Added demo doc site without contents [GSoD] Added demo doc site without contents Nov 2, 2020
@iamrajiv iamrajiv closed this Nov 2, 2020
@iamrajiv iamrajiv reopened this Nov 2, 2020
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited about this, but we can't merge this if it means removing the existing pages. I think I was unclear in my suggestion, do you think you could add back the content 😁?

docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_includes/comments.html Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@iamrajiv iamrajiv changed the title [GSoD] Added demo doc site without contents [GSoD] Added new doc site for grpc-gateway Nov 2, 2020
@iamrajiv iamrajiv changed the title [GSoD] Added new doc site for grpc-gateway [GSoD] Added new documentation website for grpc-gateway Nov 2, 2020
@iamrajiv iamrajiv changed the title [GSoD] Added new documentation website for grpc-gateway [GSoD] Added new documentation website for gRPC-Gateway Nov 2, 2020
@iamrajiv iamrajiv closed this Nov 2, 2020
@iamrajiv iamrajiv reopened this Nov 2, 2020
@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #1786 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1786   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          34       34           
  Lines        3615     3615           
=======================================
  Hits         2071     2071           
  Misses       1284     1284           
  Partials      260      260           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d0cfc...18de263. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, one more round of changes and we can merge this ❤️.

docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
docs/usegotemplates.md Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/.gitignore Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
docs/_config.yml Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst merged commit fbc7467 into grpc-ecosystem:master Nov 3, 2020
@johanbrandhorst
Copy link
Collaborator

Great work so far @iamrajiv, really excited to see what the users are going to think about this!

@iamrajiv iamrajiv changed the title [GSoD] Added new documentation website for gRPC-Gateway [GSoD 2020] Added new documentation website for gRPC-Gateway May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants