Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes generate_unbound_methods as protoc_gen_openapiv2 rule attr #1793

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Exposes generate_unbound_methods as protoc_gen_openapiv2 rule attr #1793

merged 1 commit into from
Nov 5, 2020

Conversation

zoido
Copy link
Contributor

@zoido zoido commented Nov 5, 2020

References to other Issues or PRs

FIXES #1792

Have you read the Contributing Guidelines?

Yes ✅

Brief description of what is fixed or changed

Adds new boolean generate_unbound_methods attribute to the protoc_gen_openapiv2 Bazel rule. When this attribute is True protoc is called also with --openapiv2_opt "generate_unbound_methods=true" flag.

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@zoido zoido marked this pull request as ready for review November 5, 2020 13:49
@codecov-io
Copy link

Codecov Report

Merging #1793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1793   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          34       34           
  Lines        3615     3615           
=======================================
  Hits         2071     2071           
  Misses       1284     1284           
  Partials      260      260           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6db09e...a951a2d. Read the comment docs.

Copy link
Collaborator

@achew22 achew22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good to me

@achew22 achew22 merged commit 3408ed9 into grpc-ecosystem:master Nov 5, 2020
@zoido zoido deleted the zoido/openapi-generate_unbound_methods branch November 5, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 protoc_gen_openapiv2 should allow to pass generate_unbound_methods option
3 participants