-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/implement response headers v2 #1841
Feature/implement response headers v2 #1841
Conversation
Not even sure if renovate cares to check this branch but it can't hurt.
…ent Field Enum,Example&Format attributes grpc-ecosystem#1729
* a bunch of whitespace/format changes... have since added this to my IDE * remove any.Any objects, and convert them to string * move runtime regex strings to global variables * update examples * update tests
* remove regex logic, and update functions to use simple booleans * cleanup example proto * enforce CanonicalMIMEHeaderKey for header name
simplifying string check Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
fix: remove string comparisons Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
* parse unsigned ints with strconv.ParseUint * update unqoute logic
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this, I hope it wasn't too much trouble adapting from v1 to v2 😄. This PR still looks great!
Pulling in changes from #1730 to v2
protoc-gen-swagger: Implement Response Header(s) object, Implement Field Enum,Example&Format attributes #1729
References to other Issues or PRs
#1729
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
I have implemented the following:
Other comments
Per the contributing guidelines I run the 2 docker commands, and attached the updated files to my PR