Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages to follow the repository transfer #192

Merged
merged 2 commits into from
Jul 15, 2016
Merged

Conversation

yugui
Copy link
Member

@yugui yugui commented Jul 13, 2016

github.com/gengo/grpc-gateway was transferred to github.com/grpc-ecosystem/grpc-gateway.

github.com/gengo/grpc-gateway was transferred to
github.com/grpc-ecosystem/grpc-gateway.
@yugui
Copy link
Member Author

yugui commented Jul 13, 2016

Question to reviewers.
What is the recommended protobuf package name for grpc-gateway?

It used to be gengo.grpc.gateway and I tentatively replaced it with grpc.gateway. Is there any other recommended option?

@zinuga
Copy link

zinuga commented Jul 13, 2016

@hsaliak any recommendation here?

@hsaliak
Copy link

hsaliak commented Jul 13, 2016

/cc @iamqizhao our Go implementation lead for his inputs.
My 2c is that grpc.gateway is suitable - this is the canonical and popular gateway implementation, and grpc.gateway is a clear name to describe the package's intent.

@tmc
Copy link
Collaborator

tmc commented Jul 14, 2016

+1 on grpc.gateway -- can this move forward as this is in a bit of an awkward state at the moment.

@iamqizhao
Copy link
Contributor

grpc.gateway sounds good.

@hsaliak
Copy link

hsaliak commented Jul 14, 2016

thanks! @yugui please feel free to merge the proposed changes.

@yugui yugui merged commit f52d055 into master Jul 15, 2016
@yugui
Copy link
Member Author

yugui commented Jul 15, 2016

Thank you for your reviews. Merged.

@yugui yugui mentioned this pull request Jul 15, 2016
@yugui yugui deleted the cleanup/transfer branch July 15, 2016 06:59
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
…nsfer

Rename packages to follow the repository transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants