runtime - export prefix constants #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some clients that map HTTP to GRPC requests (e.g. for tracing purposes) need to know how this library maps HTTP requests to gRPC requests. Rather than hardcoding it in their code, I think that users should be able to import this variable so that future gprc-gateway changes do not (transparently) break this functionality.
|
LGTM. But cla/google bot failed to check if you have signed a [CLA].(https://cla.developers.google.com/clas). |
|
@yugui - I have signed (and had merged code already). CLA is under philip at staffjoy.com or mail at philipithomas.com |
|
Thank you for your contribution! |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients that map HTTP to GRPC requests (e.g. for tracing purposes or for having a load balancer denote an external ip) need to know how this library maps HTTP to gRPC. Rather than hardcoding the prefix in their code, I think that users should be able to import this variable so that future gprc-gateway changes do not (transparently) break this functionality.
(and I'm writing a client right now that would benefit from this)