Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-openapiv2: Support all HTTP methods supported in OpenAPI v2 #2726

Merged
merged 3 commits into from
May 30, 2022
Merged

protoc-gen-openapiv2: Support all HTTP methods supported in OpenAPI v2 #2726

merged 3 commits into from
May 30, 2022

Commits on May 29, 2022

  1. protoc-gen-openapiv2: Fully support all HTTP methods in OpenAPI 

    The handling for mappings with the same path and method caused a crash
when provided with an operation with a HEAD, OPTIONS, or TRACE HTTP
method, which are all technically supported by OpenAPI.

Also fix this same crash when an unsupported HTTP method is provided
    @mnito
    mnito committed May 29, 2022
    Configuration menu
    Copy the full SHA
    c0c6ed4 View commit details
    Browse the repository at this point in the history

  2. Add HEAD, OPTIONS, and TRACE examples to a_bit_of_everything.proto 

    Implement examples in server
Test examples in integration tests
Regenerate files
    @mnito
    mnito committed May 29, 2022
    Configuration menu
    Copy the full SHA
    7a77588 View commit details
    Browse the repository at this point in the history

  3. Remove TRACE from OpenAPI generation 

    While TRACE is supported in OpenAPI v3, it is not supported in v2
    @mnito
    mnito committed May 29, 2022
    Configuration menu
    Copy the full SHA
    723efd0 View commit details
    Browse the repository at this point in the history