fixes package name override doesn't work #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@favadi thank you for your contribution -- have you signed the CLA? could you include a test case please? |
|
I signed the CLA but the PR needs rebase, will do it soon. |
favadi
force-pushed
the
package-name-override
branch
from
cadaaec
to
3d13f72
Compare
favadi
force-pushed
the
package-name-override
branch
from
3d13f72
to
f01ef06
Compare
|
@tmc I rebased this PR and add a test case to show the problem. |
tamalsaha
pushed a commit
to gomodules/grpc-gateway
that referenced
this pull request
May 13, 2017
* adds a test case for package overriding * fixes package name override doesn't work * sanitizes package name
tamalsaha
pushed a commit
to gomodules/grpc-gateway
that referenced
this pull request
May 31, 2017
* adds a test case for package overriding * fixes package name override doesn't work * sanitizes package name
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* adds a test case for package overriding * fixes package name override doesn't work * sanitizes package name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed failed tests in #207.
option go_package = "github.com/9bug/bug;pb";option go_package = "github.com/9bug/bug-1";