Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable parsing enums from query parameters #314

Merged
merged 1 commit into from
Feb 17, 2017
Merged

enable parsing enums from query parameters #314

merged 1 commit into from
Feb 17, 2017

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Feb 17, 2017

  • parses enumeration strings and integer values
  • range checks both the string and integer form

- parses enumeration strings and integer values
- range checks both the string and integer form

Fixes #166
@tmc
Copy link
Collaborator

tmc commented Feb 17, 2017

@tzneal thank you for your contribution!

Can you sign the google CLA?

@tzneal
Copy link
Contributor Author

tzneal commented Feb 17, 2017

I've signed the one at https://cla.developers.google.com/clas already. Is there another?

@tmc
Copy link
Collaborator

tmc commented Feb 17, 2017

@tzneal no you just needed to comment to have it update the status. Thank you.

@tmc tmc merged commit fdf0869 into grpc-ecosystem:master Feb 17, 2017
@tzneal tzneal deleted the implement-enum-as-params branch March 2, 2017 12:56
@tamalsaha tamalsaha mentioned this pull request Mar 30, 2017
1 task
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
…arams

enable parsing enums from query parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants