Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: fix properly and change to Outgoing #361

Merged
merged 1 commit into from
Apr 17, 2017
Merged

metadata: fix properly and change to Outgoing #361

merged 1 commit into from
Apr 17, 2017

Conversation

tmc
Copy link
Collaborator

@tmc tmc commented Apr 17, 2017

I was hasty in my modification before. As we're pre-call here this should use outgoing not incoming.

@tmc tmc requested a review from achew22 April 17, 2017 08:07
achew22
achew22 approved these changes Apr 17, 2017
View reviewed changes
Copy link
Collaborator

@achew22 achew22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good, but my lgtm was wrong last time. Sorry about that.

@tmc
Copy link
Collaborator Author

tmc commented Apr 17, 2017

It was posted in haste. Thanks.

@tmc tmc merged commit b75dbe3 into grpc-ecosystem:master Apr 17, 2017
@tmc tmc deleted the outgoing branch April 17, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achew22 achew22 achew22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmc @achew22