Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference import grpc Status to suppress unused errors. #387

Merged
merged 1 commit into from
May 13, 2017

Conversation

tamalsaha
Copy link
Collaborator

@tamalsaha tamalsaha commented May 13, 2017

Here is an example proto file that resulted in unused errors:

syntax = "proto3";

package appscode.ci.v1beta1;

option go_package = "v1beta1";

import "google/api/annotations.proto";
import "appscode/api/annotations.proto";

service Metadata {
  rpc ServerInfo(dtypes.VoidRequest) returns (ServerInfoResponse) {
    option (google.api.http) = {
      get : "/ci/v1beta1/metadata/server-info/json"
    };
  }
}

message ServerInfoResponse {
  string provider = 1;
  string server_url = 2;
  string ca_cert = 3;
}

@tamalsaha
Copy link
Collaborator Author

tamalsaha commented May 13, 2017

Basically if you have a service that does not use any path/query parameters, this error happens. This bug was introduced in #378

cc: @kazegusuri @tmc

@tmc
Copy link
Collaborator

tmc commented May 13, 2017

@tamalsaha thanks for the patch.

@tmc
Copy link
Collaborator

tmc commented May 13, 2017

some files need to be re-generated.

@tamalsaha
Copy link
Collaborator Author

Regenerated example protos

@tmc tmc merged commit f6f92fc into grpc-ecosystem:master May 13, 2017
@tamalsaha tamalsaha deleted the fix-status branch May 13, 2017 22:19
tamalsaha added a commit to gomodules/grpc-gateway that referenced this pull request May 31, 2017
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants