Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return codes.InvalidArgument to rather return HTTP 400 instead of HTTP 500 #409

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Return codes.InvalidArgument to rather return HTTP 400 instead of HTTP 500 #409

merged 1 commit into from
Jun 15, 2017

Conversation

vaporz
Copy link
Contributor

@vaporz vaporz commented Jun 5, 2017

1, Same change in "template.go" with #397 .
2, Add a test case.
3, Update examples

@vaporz vaporz mentioned this pull request Jun 5, 2017
@vaporz
Copy link
Contributor Author

vaporz commented Jun 5, 2017

Ah...."Waiting for status to be reported", why....

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@vaporz
Copy link
Contributor Author

vaporz commented Jun 5, 2017

I signed it!

@vaporz
Copy link
Contributor Author

vaporz commented Jun 5, 2017

zzzZZZ

@googlebot
Copy link

CLAs look good, thanks!

@vaporz
Copy link
Contributor Author

vaporz commented Jun 5, 2017

ping @tamalsaha , @tmc
Thank you.

@pieterlouw
Copy link

I will close #397 as this PR have test case and examples

@vaporz
Copy link
Contributor Author

vaporz commented Jun 14, 2017

Hi, any comments on this PR?
Thanks!

@tmc tmc changed the title ISSUE#405: customize the error return Return codes.InvalidArgument to rather return HTTP 400 instead of HTTP 500 Jun 14, 2017
Copy link
Collaborator

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @achew22 @tamalsaha one of you want to weigh in?

@tamalsaha
Copy link
Collaborator

LGTM.

@achew22 achew22 merged commit d64f531 into grpc-ecosystem:master Jun 15, 2017
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants