Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle wrapper proto types as primitives #412

Closed
wants to merge 1 commit into from
Closed

Handle wrapper proto types as primitives #412

wants to merge 1 commit into from

Conversation

nirshirion
Copy link

@tmc
Copy link
Collaborator

tmc commented Jun 20, 2017

Thanks for your contribution. Have you signed the CLA?

Can you include a test demonstrating this behavior change?

@achew22
Copy link
Collaborator

achew22 commented Oct 26, 2017

@nirshirion I would like to merge this if it is possible. Would you be willing to sign the CLA?

@achew22
Copy link
Collaborator

achew22 commented Nov 8, 2017

@nirshirion, could you sign the CLA and add some tests so that we can merge this?

@achew22
Copy link
Collaborator

achew22 commented Nov 8, 2017

The CLA bot web UI is reporting that you have signed the CLA. Looks like we just need a test and we can submit this. I would love to have it in the project.

@mattolson
Copy link

👍 We are running into this as well, and feel that this should be handled transparently by grpc-gateway. Are there any blockers to merging this?

@achew22
Copy link
Collaborator

achew22 commented Jan 25, 2018

@mattolson, I don't think there is anything blocking us merging this except test coverage

@achew22
Copy link
Collaborator

achew22 commented Feb 16, 2018

@nirshirion, any chance we could have you come back and add tests to this PR? I would love to merge it!

@mattolson, if you want to take a whack at extending this PR by pulling it into your workspace and writing the tests for it, I would also be happy to merge that.

@johanbrandhorst
Copy link
Collaborator

Support for this was merged with #695 and #496 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants