Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some steps to fix Travis CI #461

Merged
merged 3 commits into from
Sep 14, 2017
Merged

Some steps to fix Travis CI #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0c62b0
Test with Go 1.9.
AlekSi Sep 13, 2017
6e5940f
Fix build.
AlekSi Sep 13, 2017
be95813
Reference Gulp by a more complete path
achew22 Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
language: go
sudo: false
go:
- 1.8.x
- 1.7.x
- tip
- 1.8.x
- 1.9.x
- master
go_import_path: github.com/grpc-ecosystem/grpc-gateway
cache:
directories:
Expand All @@ -28,7 +29,7 @@ script:
- if (go version | grep -q 1.8) && [ -z "${GATEWAY_PLUGIN_FLAGS}" ]; then test -z "$(git status --porcelain)" || (git status; git diff; exit 1); fi
- env GLOG_logtostderr=1 go test -race -v github.com/grpc-ecosystem/grpc-gateway/...
- make lint
- sh -c 'cd examples/browser && gulp'
- sh -c 'cd examples/browser && node ./node_modules/gulp/bin/gulp'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do $(npm bin)/gulp?

env:
global:
- "PATH=$PATH:$HOME/local/bin"
Expand Down
2 changes: 1 addition & 1 deletion examples/server/a_bit_of_everything.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (s *_ABitOfEverythingServer) List(_ *empty.Empty, stream examples.StreamSer
}

// return error when metadata includes error header
if header, ok := metadata.FromContext(stream.Context()); ok {
if header, ok := metadata.FromIncomingContext(stream.Context()); ok {
if v, ok := header["error"]; ok {
stream.SetTrailer(metadata.New(map[string]string{
"foo": "foo2",
Expand Down