protoc-gen-grpc-gateway: flip request_context default to true #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to grpc-ecosystem#473. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
flip-default-for-request-context
branch
from
f0b2b8d
to
aa16e32
Compare
Since it's request_context=true by default now Signed-off-by: Stephan Renatus <[email protected]>
|
No love for this? 💔 |
|
Not to imply that it isn't a desirable change but it is definitely a breaking change since anyone using go 1.7 (which is part of our testing matrix) is going to have a bad time with this. |
|
@achew22 Thanks for the input. Is it still desirable to have 1.7 supported and as part of the testing matrix? 😃 |
|
I just tagged a new release and as such it is a great time to be turning on new features like this. If people have issues they can use the tag v1.3 |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
…cosystem#474) Follow up to grpc-ecosystem#473. Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #473.